Handful of openMP type, syntax violations in AB 6.8.1

Documentation, Web site and code modifications

Moderators: baguetl, routerov

Locked
WoodDM
Posts: 10
Joined: Tue Mar 02, 2010 5:52 am

Handful of openMP type, syntax violations in AB 6.8.1

Post by WoodDM » Thu Jun 30, 2011 10:32 pm

My compliments to those responsible for 6.8.1!

Out of curiosity, I tried building 6.8.1 with gcc 4.5 and its gfortran counterpart [on Mac OS 10.6.8] by using the COMPILER flags

CFLAGS_EXTRA="-fopenmp"
FCFLAGS_EXTRA="-fopenmp"

It appears as if only minor errors prevented AB from building, so I bring these to your attention in case OpenMP support via compiler flags becomes a priority.
Here's the output of a 'script' command in which I tried a build:

Code: Select all

Making all in 52_fft_mpi_noabirule
/opt/local/bin/gfortran-mp-4.5 -m64 -DHAVE_CONFIG_H -I. -I../.. -I../../src/incs -I../../src/incs   -ffree-form -J/Volumes/Backups/AntbeeHome/dmwood/incoming/abinit-6.8.1/src/mods -O2 -mtune=native -march=native -mfpmath=sse -m64 -g -ffree-line-length-none -Wstrict-aliasing=2 -fopenmp -c -o back.o back.F90
back.F90:124.64:

!$omp shared(ndat,n1,n2,n3,nd1,nd2,nd3,nd2proc,nd3proc,mpi_enreg%me_fft,mpi_enr
                                                                1
Error: Syntax error in OpenMP variable list at (1)
back.F90:383.18:

!$omp end parallel
                  1
Error: Unexpected !$OMP END PARALLEL statement at (1)

/opt/local/bin/gfortran-mp-4.5 -m64 -DHAVE_CONFIG_H -I. -I../.. -I../../src/incs -I../../src/incs   -ffree-form -J/Volumes/Backups/AntbeeHome/dmwood/incoming/abinit-6.8.1/src/mods -O2 -mtune=native -march=native -mfpmath=sse -m64 -g -ffree-line-length-none -Wstrict-aliasing=2 -fopenmp -c -o forw.o forw.F90
forw.F90:137.64:

!$omp shared(ndat,n1,n2,n3,nd1,nd2,nd3,nd2proc,nd3proc,mpi_enreg%me_fft,mpi_enr
                                                                1
Error: Syntax error in OpenMP variable list at (1)
forw.F90:312.18:

!$omp end parallel
                  1
Error: Unexpected !$OMP END PARALLEL statement at (1)

Making all in 53_ffts
/opt/local/bin/gfortran-mp-4.5 -m64 -DHAVE_CONFIG_H -I. -I../.. -I../../src/incs -I../../src/incs   -ffree-form -J/Volumes/Backups/AntbeeHome/dmwood/incoming/abinit-6.8.1/src/mods -O2 -mtune=native -march=native -mfpmath=sse -m64 -g -ffree-line-length-none -Wstrict-aliasing=2 -fopenmp -c -o fftw3_fourwf.o fftw3_fourwf.F90
fftw3_fourwf.F90:435.26:

!$   call sg_fftrisc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istw
                          1
Error: Symbol 'cplex' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.37:

!$   call sg_fftrisc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istw
                                     1
Error: Symbol 'dum_denpot' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.55:

!$   call sg_fftrisc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istw
                                                       1
Error: Symbol 'dum_fofgin' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.91:

risc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istwf_k,dum_gvec,gve
                                                                           1               
Error: Symbol 'dum_gvec' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.44:

!$   call sg_fftrisc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istw
                                            1
Error: Symbol 'fofgin' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.96:

cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istwf_k,dum_gvec,gvec,&
                                                                           1                     
Error: Symbol 'gvec' at (1) has no IMPLICIT type
fftw3_fourwf.F90:435.82:

ll sg_fftrisc(cplex,dum_denpot,fofgin,dum_fofgin,fofr,gbound,gbound,istwf_k,dum
                                                                           1       
Error: Symbol 'istwf_k' at (1) has no IMPLICIT type
fftw3_fourwf.F90:436.25:

!$&    mgfft,ngfft,npwwfn,npwwfn,ldx,ldy,ldz,option,weight)
                         1
Error: Symbol 'npwwfn' at (1) has no IMPLICIT type
fftw3_fourwf.F90:436.51:

!$&    mgfft,ngfft,npwwfn,npwwfn,ldx,ldy,ldz,option,weight)
                                                   1
Error: Symbol 'option' at (1) has no IMPLICIT type
fftw3_fourwf.F90:436.58:

!$&    mgfft,ngfft,npwwfn,npwwfn,ldx,ldy,ldz,option,weight)
                                                          1
Error: Symbol 'weight' at (1) has no IMPLICIT type
make[3]: *** [fftw3_fourwf.o] Error 1
/opt/local/bin/gfortran-mp-4.5 -m64 -DHAVE_CONFIG_H -I. -I../.. -I../../src/incs -I../../src/incs   -ffree-form -J/Volumes/Backups/AntbeeHome/dmwood/incoming/abinit-6.8.1/src/mods -O2 -mtune=native -march=native -mfpmath=sse -m64 -g -ffree-line-length-none -Wstrict-aliasing=2 -fopenmp -c -o sphere_fft.o sphere_fft.F90
sphere_fft.F90:111.21:

!$OMP END PARALLEL DO
                     1
Error: Unexpected !$OMP END PARALLEL DO statement at (1)
sphere_fft.F90:112.19:

 cfft(:,:,:,:)=zero
                   1
Error: Unexpected assignment statement at (1)
sphere_fft.F90:113.74:

!$OMP PARALLEL DO PRIVATE(i1,i2,i3,idat,ipw) SHARED(cfft,cg,kg_k,ndat,npw)
                                                                          1
Error: Unexpected !$OMP PARALLEL DO statement at (1)
sphere_fft.F90:241.21:

!$OMP END PARALLEL DO
                     1
Error: Unexpected !$OMP END PARALLEL DO statement at (1)
sphere_fft.F90:242.19:

 cfft(:,:,:,:)=zero
                   1
Error: Unexpected assignment statement at (1)
sphere_fft.F90:243.74:

!$OMP PARALLEL DO PRIVATE(i1,i2,i3,idat,ipw) SHARED(cfft,cg,kg_k,ndat,npw)
                                                                          1
Error: Unexpected !$OMP PARALLEL DO statement at (1)


Best wishes!

User avatar
jbeuken
Posts: 365
Joined: Tue Aug 18, 2009 9:24 pm
Contact:

Re: Handful of openMP type, syntax violations in AB 6.8.1

Post by jbeuken » Fri Jul 01, 2011 9:26 pm

Hi,

it's perhaps a good idea, if OpenMPI support is becoming a priority , to have a bot in the testfarm for testing the OpenMPI

thanks

jmb
------
Jean-Michel Beuken
Computer Scientist

Locked